[wp-trac] Re: [WordPress Trac] #3254: Plugin sandboxing

WordPress Trac wp-trac at lists.automattic.com
Thu Jan 25 22:40:42 GMT 2007


#3254: Plugin sandboxing
------------------------------+---------------------------------------------
 Reporter:  markjaquith       |        Owner:  markjaquith
     Type:  defect            |       Status:  assigned   
 Priority:  normal            |    Milestone:  2.2        
Component:  Administration    |      Version:  2.1        
 Severity:  normal            |   Resolution:             
 Keywords:  plugin has-patch  |  
------------------------------+---------------------------------------------
Comment (by westi):

 Replying to [comment:3 markjaquith]:
 > 002 patch prevents you from FUBARing your wp-admin when editing active
 plugins.
 >
 > It works by de-activating the plugin after the edit redirect.  The edit
 redirect dynamically includes the plugin (nonce protected, natch), and
 redirects to the "success" message (which silently re-activates) if it
 works, and the "error" message if it doesn't work.
 >
 > There is a message at near the "Update" button for active editable
 plugins that warns that fatal errors will result in the plugin being
 deactivated.
 >
 > I think deactivation is better than discarding the changes.  Someone
 would be very frustrated if a whole bunch of changes went down the tubes
 because they forgot a semi-colon.
 >

 This all looks really good.

 My only plea would be give the user a button on the page that allows them
 to reactivate the plugin when the fix the error - maybe a update and
 reactivate button or updating a plugin that was active should attempt to
 reactivate it as well.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3254#comment:4>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list