[wp-trac] Re: [WordPress Trac] #5483: menu-header.php enhancements

[WordPress Trac]

#5483: menu-header.php enhancements
----------------------------+-----------------------------------------------
 Reporter:  huwr            |        Owner:  anonymous
     Type:  enhancement     |       Status:  new      
 Priority:  normal          |    Milestone:  2.4      
Component:  Administration  |      Version:  2.4      
 Severity:  normal          |   Resolution:           
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Changes (by DD32):

  * version:  => 2.4
  * type:  defect => enhancement
  * milestone:  2.3.2 => 2.4

Comment:

 IMO:
 {{{
  $href = "admin.php?page={$submenu[$item[2]][0][2]}";
 }}}
 Should be written as:
 {{{
  $href = 'admin.php?page=' . $submenu[$item[2]][0][2];
 }}}

 At least for the 2nd and 4th items where theres no reason for it to be
 contained within a string, Its just one of those smalll optimization
 things which makes sense to me.

 I'm aware the exact same thing is used elsewhere within the file though

 Also pushing to 2.4 as new features go into trunk, and then the
 possibility of backporting it to maintainence releases are considered.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5483#comment:1>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software