[wp-trac] Re: [WordPress Trac] #2927: hooks for upgrade and pre_upgrade

[WordPress Trac]

#2927: hooks for upgrade and pre_upgrade
---------------------------------------+------------------------------------
 Reporter:  ryanscheuermann            |        Owner:  anonymous
     Type:  enhancement                |       Status:  new      
 Priority:  normal                     |    Milestone:  2.4      
Component:  Administration             |      Version:  2.1      
 Severity:  normal                     |   Resolution:           
 Keywords:  upgrade plugin-management  |  
---------------------------------------+------------------------------------
Comment (by darkdragon):

 Added a simple patch that adds this functionality. Basically, I'm content
 in that it does what the enhancement states. However, I would feel better
 if there the inclusion was in a sandbox, so that if the plugin dies or
 errors out, it won't affect the upgrade and will just disable the plugin.

 I don't include that logic in this patch, because I feel don't feel that
 it will be an issue and might add unnecessary overhead. The next patch,
 will have this functionality base off of the plugin.php sandbox code. I'm
 not exactly sure how that code might be applied to the current
 implementation.

 Plugin authors have to be made aware that if this patch were to be part of
 core, they would have to pay attention to how they write their plugins. In
 that way, the sandbox is almost required.

 Oh the patch also assumes that none of patches are evil.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2927#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software