[wp-trac] [WordPress Trac] #5448: Comments-template echoes strange comment link

WordPress Trac wp-trac at lists.automattic.com
Mon Dec 10 12:43:22 GMT 2007


#5448: Comments-template echoes strange comment link
----------------------+-----------------------------------------------------
 Reporter:  reinkim   |       Owner:  anonymous
     Type:  defect    |      Status:  new      
 Priority:  normal    |   Milestone:  2.4      
Component:  Template  |     Version:  2.4      
 Severity:  normal    |    Keywords:           
----------------------+-----------------------------------------------------
 After applying changeset [6368] comments_popup_link function in wp-
 includes/comments-template.php behalves differently from previous
 versions.

 In [6368] comments_popup_link assembles $comments_popup_link variable, but
 in some execution path there are codes which ''echo'' the output, which
 should be appended to $comments_popup_link variable.



 Problematic codes (all source lines from wp-includes/comments-template)
  * function comments_number echoes its result
  * function comments_link echoes its output

 I made fix to the source (attached diff. file) which may need some tests.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5448>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list