[wp-trac] Re: [WordPress Trac] #5418: remove unused variables from wp-admin/*.php

WordPress Trac wp-trac at lists.automattic.com
Sun Dec 9 00:15:49 GMT 2007


#5418: remove unused variables from wp-admin/*.php
-----------------------+----------------------------------------------------
 Reporter:  DD32       |        Owner:  anonymous
     Type:  defect     |       Status:  reopened 
 Priority:  normal     |    Milestone:  2.4      
Component:  General    |      Version:  2.4      
 Severity:  normal     |   Resolution:           
 Keywords:  has-patch  |  
-----------------------+----------------------------------------------------
Comment (by DD32):

 Replying to [comment:14 JeremyVisser]:
 > But in this instance, the value is being ignored, so ''semantically'', I
 believe it's better to do {{{do_action()}}}. (Although, I think
 {{{do_action()}}} uses {{{apply_filters()}}} internally, so it's
 definitely not for optimisation reasons.)

 Ah your right, I for some reason had it in my mind, that the action, and
 filters were stored in seperate arrays.

 I'll make the change and then post a patch back.[[BR]]
 I'll also add a diff of xmlrpc.php so as to show what was removed from it
 when spacings are ignored. (not intended to be commited -- just for
 information purposes)

-- 
Ticket URL: <http://trac.wordpress.org/ticket/5418#comment:15>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list