[wp-trac] Re: [WordPress Trac] #5418: remove unused variables from wp-admin/*.php

WordPress Trac wp-trac at lists.automattic.com
Fri Dec 7 09:18:47 GMT 2007

#5418: remove unused variables from wp-admin/*.php
 Reporter:  DD32       |        Owner:  anonymous
     Type:  defect     |       Status:  reopened 
 Priority:  normal     |    Milestone:  2.4      
Component:  General    |      Version:  2.4      
 Severity:  normal     |   Resolution:           
 Keywords:  has-patch  |  
Comment (by Nazgul):

 That last patch introduced this:
 '''apply_filters('wp_create_file_in_uploads', $file); // replicate'''

 The output of the filter was removed, because it wasn't used in the rest
 of the code, but doesn't that imply that the entire apply_filters call can
 be removed as well? Why filter if you throw away the output.

 This happens in wp-app.php (415), wp-admin/custom-header.php (231) and wp-
 admin/link-import.php (126).

Ticket URL: <http://trac.wordpress.org/ticket/5418#comment:10>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list