[wp-trac] Re: [WordPress Trac] #4743: Fix cache stomping in get_bookmarks()

[WordPress Trac]

#4743: Fix cache stomping in get_bookmarks()
----------------------------+-----------------------------------------------
 Reporter:  josephscott     |        Owner:  anonymous  
     Type:  defect          |       Status:  new        
 Priority:  normal          |    Milestone:  2.3 (trunk)
Component:  Administration  |      Version:             
 Severity:  normal          |   Resolution:             
 Keywords:  has-patch       |  
----------------------------+-----------------------------------------------
Changes (by josephscott):

 * cc: josephscott (added)

Comment:

 After looking at this further the diff has problems and really isn't
 needed.

 My initial thought was that the cache was getting stomped because it
 wasn't breaking it out into enough different groups.  This was true, but
 not really the issue.

 The problem is using wp_cache_add, which is fine if you are storing one
 "thing", but we have an array of things that change.  So we should be
 using wp_cache_set.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4743#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software