[wp-trac] Re: [WordPress Trac] #4732: $guessurl wrong in install.php

WordPress Trac wp-trac at lists.automattic.com
Mon Aug 13 17:44:56 GMT 2007


#4732: $guessurl wrong in install.php
----------------------------------------------+-----------------------------
 Reporter:  ar0n                              |        Owner:  anonymous
     Type:  defect                            |       Status:  new      
 Priority:  normal                            |    Milestone:  2.2.3    
Component:  Administration                    |      Version:  2.2      
 Severity:  major                             |   Resolution:           
 Keywords:  $guessurl  install.php has-patch  |  
----------------------------------------------+-----------------------------
Comment (by westi):

 /me wonders out loud ...

 Are there any other places where we assume the string we recieve via the
 GET request has had the http://domain.name stripped from the front?

 Should we also move the duplicated code to a function rather than copy and
 pasting the fix into two places maybe something like:

 {{{guess_blog_root_url}}} in wp-admin/includes/upgrade.php that returns
 the full root url for us.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4732#comment:2>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list