[wp-trac] Re: [WordPress Trac] #4169: Bring widgets into WordPress core

WordPress Trac wp-trac at lists.automattic.com
Mon Apr 30 21:22:52 GMT 2007


#4169: Bring widgets into WordPress core
-----------------------------+----------------------------------------------
 Reporter:  rob1n            |        Owner:  rob1n   
     Type:  task             |       Status:  reopened
 Priority:  highest omg bbq  |    Milestone:  2.2     
Component:  General          |      Version:          
 Severity:  blocker          |   Resolution:          
 Keywords:                   |  
-----------------------------+----------------------------------------------
Comment (by filosofo):

 New problem: the {{{maybe_disable_automattic_widgets}}} function doesn't
 do any good, because what happens is that wp-includes/widgets.php gets
 included *before* the widgets plugin (hence all the checks in wp-
 includes/widgets.php for existing widgets functions are worthless), and it
 gets included *before* upgrade-functions.php has a chance to define
 {{{maybe_disable_automattic_widgets}}}.  You end up with a fatal error,
 even when just requesting wp-admin/upgrade.php

 So it makes sense to check for the widgets plugin in wp-
 includes/widgets.php then deactivate it.

 My patch does that, and it removes the extraneous existing widget function
 checks.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4169#comment:47>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list