[wp-trac] Re: [WordPress Trac] #4136: Admin should not by stopped from uploading any type of file

WordPress Trac wp-trac at lists.automattic.com
Mon Apr 30 06:16:47 GMT 2007


#4136: Admin should not by stopped from uploading any type of file
-------------------------------------+--------------------------------------
 Reporter:  foolswisdom              |        Owner:  rob1n   
     Type:  enhancement              |       Status:  reopened
 Priority:  normal                   |    Milestone:  2.3     
Component:  Administration           |      Version:  2.2     
 Severity:  normal                   |   Resolution:          
 Keywords:  has-patch needs-testing  |  
-------------------------------------+--------------------------------------
Changes (by technosailor):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Ok, here's a diff. All this does is allow an admin to upload a valid
 mimetype image without the stripping of the dot between filename and ext.
 Non-admin users will still have valid filenames mangled which is exactly
 opposite of how it was with the previous changeset. I spent some time
 reviewing mods to wp-admin/admin-functions.php and wp-
 includes/functions.php in SVN and I can't really determine where this
 greedy stripping is occurring.

 Regardless, I'm reopening as I don't believe this is expected behavior. If
 we don't want non-admins to upload images, let's take away the uploader -
 not change their files behind their backs. If we DO want to allow non-
 admins to upload images, then my changeset does not address this issue and
 we need to find out where those greedy regexes (or whatever) are mangling
 the files.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4136#comment:13>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list