[wp-trac] Re: [WordPress Trac] #4169: Bring widgets into WordPress
core
WordPress Trac
wp-trac at lists.automattic.com
Sat Apr 21 05:33:55 GMT 2007
#4169: Bring widgets into WordPress core
-----------------------------+----------------------------------------------
Reporter: rob1n | Owner: rob1n
Type: task | Status: new
Priority: highest omg bbq | Milestone: 2.2
Component: General | Version:
Severity: blocker | Resolution:
Keywords: |
-----------------------------+----------------------------------------------
Comment (by ryan):
Extra close paren on line 16 of widgets.js.php. Warnings on lines 11 and
12 of wp-admin/widgets.php because $wp_registered_widgets is not
initialized. wp-includes/widgets.php: $sidbar typo on line 59,
$wp_registered_sidebar_defaults on line 133 does not match
$wp_register_sidebar_defaults global, $items not initialized on line 771.
Also, wp_widget_recent_entries() looks like it is missing a brace. I
suggest just returning immediately if !have_posts() rather than putting
the positive case inside an if block. Also, using the if:endif; style
blocks for the function_exists() checks and not indenting the functions
within the if:endif block is easier to read, IMO.
--
Ticket URL: <http://trac.wordpress.org/ticket/4169#comment:11>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list