[wp-trac] Re: [WordPress Trac] #4094: get_pages: add query hooks, wpcache argument hooks

WordPress Trac wp-trac at lists.automattic.com
Thu Apr 5 20:07:28 GMT 2007


#4094: get_pages: add query hooks, wpcache argument hooks
----------------------------+-----------------------------------------------
 Reporter:  kevinB          |        Owner:  rob1n
     Type:  enhancement     |       Status:  new  
 Priority:  normal          |    Milestone:  2.2  
Component:  General         |      Version:       
 Severity:  normal          |   Resolution:       
 Keywords:  get_pages hook  |  
----------------------------+-----------------------------------------------
Comment (by kevinB):

 I've come to some clearer thinking on the results filter placement.

 If the cache retrieval is run through the same filter, there is no need to
 filter prior to cache storage.  It seems safer to leave the actual cache
 storage unfiltered so it's not invalid after a filtering plugin is
 removed.

 That means get_pages is the one that should change.

 In fact, there is a '''defect''' in the current code:
 The current placement of the post-query "get_pages" filter causes
 get_page_children contributions to be filtered on cache retrieval, but not
 after query.  End user could get a different answer the first time they
 ask.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/4094#comment:5>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list