[wp-trac] Re: [WordPress Trac] #2994: Theme files cannot be edited when theme's directory has certain characters in it

WordPress Trac wp-trac at lists.automattic.com
Mon Oct 2 19:29:32 GMT 2006


#2994: Theme files cannot be edited when theme's directory has certain characters
in it
----------------------------------------------------------------------+-----
 Reporter:  trasnam                                                   |        Owner:  ryan  
     Type:  defect                                                    |       Status:  closed
 Priority:  high                                                      |    Milestone:  2.0.5 
Component:  Administration                                            |      Version:  2.0.4 
 Severity:  normal                                                    |   Resolution:  fixed 
 Keywords:  theme editor bracket parenthesis spaces braces has-patch  |  
----------------------------------------------------------------------+-----
Comment (by ryan):

 Instead of modifying wp_redirect(), let's go the more conservative route
 for 2.0.5 and modify theme-editor.php.  I changed it to strip CRLF and
 nulls pass everything else through.  Any other badness should be caught
 with the allowed_files check.  We can reconsider what to do with
 wp_redirect() in 2.1.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2994>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list