[wp-trac] Re: [WordPress Trac] #2682: Remove db store of absolute path for uploads

WordPress Trac wp-trac at lists.automattic.com
Mon May 1 21:53:23 GMT 2006


#2682: Remove db store of absolute path for uploads
----------------------------+-----------------------------------------------
       Id:  2682            |      Status:  new                     
Component:  Administration  |    Modified:  Mon May  1 21:53:22 2006
 Severity:  normal          |   Milestone:  2.1                     
 Priority:  normal          |     Version:  2.1                     
    Owner:  anonymous       |    Reporter:  ryanscheuermann         
----------------------------+-----------------------------------------------
Comment (by davidhouse):

 Hi Ryan, three things:

 1.

 {{{
 -       if ( $dir == ABSPATH ) { //the option was empty
 -               $dir = ABSPATH . 'wp-content/uploads';
 -       }
 }}}

 Why are you stripping that code? I would expect it to become:

 {{{
 if ( empty($dir) ) {
         $dir = 'wp-content/uploads';
 }
 }}}

 2. The ABSPATH repition has got to go. Your idea about tossing around
 relative paths sounds good.
 3. More filters = more fun. This is one area where filters are lacking.
 It's "define the whole function or nothing".

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2682>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list