[wp-trac] Re: [WordPress Trac] #1082: Superfluous newlines added to
.htaccess on update
WordPress Trac
wp-trac at lists.automattic.com
Mon Mar 13 19:33:32 GMT 2006
#1082: Superfluous newlines added to .htaccess on update
---------------------+------------------------------------------------------
Id: 1082 | Status: new
Component: General | Modified: Mon Mar 13 19:33:32 2006
Severity: minor | Milestone: 2.1
Priority: normal | Version: 2.0
Owner: ryan | Reporter: Blu_Matt
---------------------+------------------------------------------------------
Changes (by abhay):
* keywords: bg|has-patch bg|needs-testing bg|commit => has-patch commit
Comment:
I may be playing semantics but the reasoning is that the code should be
checking if the N-th element in the array is the second to last element
not if the N+1-th element is the last element.
This may be a little more meaninful:
{{{
+ if ($state) {
+ fwrite($f, "{$markerline}");
+ if ( $n < count($markerdata) - 1)
+ fwrite($f, "\n");
+ }
}}}
Either, this seems ready for a commit.
--
Ticket URL: <http://trac.wordpress.org/ticket/1082>
WordPress Trac <http://wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list