[wp-trac] Re: [WordPress Trac] #2395: Minor addition to _page_level_out

WordPress Trac wp-trac at lists.automattic.com
Thu Jul 20 17:45:39 GMT 2006


#2395: Minor addition to _page_level_out
-------------------------+--------------------------------------------------
 Reporter:  anselm1109   |        Owner:  markjaquith
     Type:  enhancement  |       Status:  assigned   
 Priority:  normal       |    Milestone:  2.1        
Component:  Template     |      Version:  2.0        
 Severity:  trivial      |   Resolution:             
 Keywords:               |  
-------------------------+--------------------------------------------------
Changes (by FireMotion):

  * milestone:  => 2.1
  * severity:  normal => trivial

Comment:

 Currently in Internet Explorer (6.0), if you define: `ul li {}` then any
 following `ul li li {}` or `ul li li li {}` doesn't work, it gets whatever
 is defined under `ul li {}` (because IE processes this as: ''any'' `li`
 that is contained within `ul`, even if nested within other tags).

 In other good browsers you can use `ul>li {}` then `ul>li>ul>li` to get
 the correct results (this is processed as: the `li` that is contained
 within `ul` but not enclosed within other tags).

 '''Back to the problem'''[[BR]]
 #2437 seems like a solution, but it only covers current items: it adds a
 class for the parent whenever a child is active. A combination of these
 two tickets would be better indeed:
 {{{
 * page_item page_item_top
   * page_item
   * page_item
 * page_item page_item_top current_page_item_top
   * page_item current_page_item
   * page_item
   * page_item
 * page_item page_item_top
 * page_item page_item_top
 }}}
 I called them `top` because these are the top items/parents. This,
 however, poses a problem. If there are sub-sub-items, what whould happen:
 1)
 {{{
 * page_item page_item_top
   * page_item page_item_parent
     * page_item page_item_parent
       * page_item
 }}}
 or 2)
 {{{
 * page_item page_item_top
   * page_item page_item_top
     * page_item page_item_top
       * page_item
 }}}
 or 3) (preferred)
 {{{
 * page_item page_item_top
   * page_item
     * page_item
       * page_item
 }}}

 Furthermore, if the function is called, and asked only to get child nodes
 of a parent, should the top node get the `page_item_top` class (it's not
 the real top item, but it's the sub-item of the node that is asked for)?

 Customization through parameters seems preferred (through
 `wp_list_pages`): `page_item_top=` or `page_item_parent=` and
 `current_item_top=` or `current_page_item_parent=`.

 In addition, fixing this ticket would obsolete #2364.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2395>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list