[wp-trac] Re: [WordPress Trac] #2516: Page order messed up with latest CVS

[WordPress Trac]

#2516: Page order messed up with latest CVS
-----------------------+----------------------------------------------------
       Id:  2516       |      Status:  reopened                
Component:  General    |    Modified:  Tue Feb 28 13:41:48 2006
 Severity:  major      |   Milestone:  2.1                     
 Priority:  low        |     Version:  2.0.1                   
    Owner:  anonymous  |    Reporter:  abbaanthony             
-----------------------+----------------------------------------------------
Changes (by markjaquith):

  * severity:  trivial => major

Comment:

 Okay, forget that second part about array_pop()... that's wrong... you
 were adding via array_unshift() so array_pop() is correct.  The problem
 was just in the break; conditional that you were checking against
 $parent->ID instead of $parents[0]->ID ... we have to check the next
 parent up.  It was breaking anytime you went up a level from a level > 2
 (i.e. 3=>2 or 4=>3).  The first parent it checked would be a sibling
 (expected) so it goes up a level.  But then it goes up another level
 because instead of checking the next parent in line, it checks the current
 parent, and so the loop runs again.

 http://txfx.net/wp2/ has a fairly comprehensive hierarchy, with 4=>3,
 4=>2, 4=>1, 3=>2, and 2=>1 transition states.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2516>
WordPress Trac <http://wordpress.org/>
WordPress blogging software