[wp-trac] Re: [WordPress Trac] #2445: comment_status and ping_status ignored on publish/first save

[WordPress Trac]

#2445: comment_status and ping_status ignored on publish/first save
----------------------------+-----------------------------------------------
       Id:  2445            |      Status:  assigned                
Component:  Administration  |    Modified:  Wed Feb 15 10:12:47 2006
 Severity:  major           |   Milestone:  2.1                     
 Priority:  high            |     Version:  2.0.1                   
    Owner:  markjaquith     |    Reporter:  Samael                  
----------------------------+-----------------------------------------------
Changes (by markjaquith):

  * keywords:  comments bg|needs-patch => comments bg|has-patch bg|2nd-
               opinion bg|dev-feedback

Comment:

 The code is currently checking if the field is empty and if so setting to
 get_settings('default_comment_status') or
 get_settings('default_ping_status')

 Of course, if you uncheck the boxes, they will be empty, so they'll be set
 to the default status.

 I think the default status should only be used to check or uncheck the
 boxes when you first load the Write screen.  If you save/publish a post
 and the settings are empty, it should treat them as unchecked and make the
 setting 'closed'

 My patch makes that change.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2445>
WordPress Trac <http://wordpress.org/>
WordPress blogging software