[wp-trac] Re: [WordPress Trac] #1955: Outgoing trackback ping could include 'charset' attribute for international trackbacks

[WordPress Trac]

#1955: Outgoing trackback ping could include 'charset' attribute for international
trackbacks
--------------------------------------------+-------------------------------
 Reporter:  matopc                          |        Owner:  anonymous
     Type:  defect                          |       Status:  new      
 Priority:  normal                          |    Milestone:  2.2      
Component:  Optimization                    |      Version:  2.0      
 Severity:  normal                          |   Resolution:           
 Keywords:  trackback charset bg|has-patch  |  
--------------------------------------------+-------------------------------
Comment (by tenpura):

 majelbstoat,[[BR]]
 It is already pluggable. You can bypass or recode the whole part through
 preprocess_comment hook.

 '''Note to matt and ryan:'''[[BR]]
 I think this encoding conversion section is one of the worst code in the
 WP. Currently only UTF-8, ISO-8859-1 and JIS input are seemingly converted
 safely and many of the rest would possibly be destroyed or result in error
 (Notice that even EUC-JP and SJIS are destroyed!).  It seems that the
 demerit of the existence of the code is bigger than the merit.

 '''Suggested Solution:'''[[BR]]
 Simply remove the input encoding conversion section and let local people
 write their own plugins.

 Reasons:
  * It is pluggable.
  * Current incomming pingback section does not have this kind of engine
 and people seem fine without it.
  * Implementing almighty input encoding conversion logic is almost
 impossible.
  * If one has proper MySQL character set settings (like skip-character-
 set-client-handshake), theoretically any foreign encoding input can be
 retrievable later on.
  * Nobody seems to like the current code.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/1955#comment:18>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software