[wp-trac] Re: [WordPress Trac] #3438: Internationalization by mistake

[WordPress Trac]

#3438: Internationalization by mistake
------------------------+---------------------------------------------------
 Reporter:  nbachiyski  |        Owner:  anonymous
     Type:  defect      |       Status:  reopened 
 Priority:  low         |    Milestone:           
Component:  Template    |      Version:  2.0.5    
 Severity:  minor       |   Resolution:           
 Keywords:  has-patch   |  
------------------------+---------------------------------------------------
Changes (by yskins):

  * status:  closed => reopened
  * resolution:  invalid =>

Comment:

 I think nbachiyski is right.

 {{{
 $url  = sprintf(__('%1$s/%2$s%3$sm%4$s%5$s%6$sw%7$s%8$d'),
 get_settings('home'), '', '?', '=', $arc_year, '&', '=',
 $arcresult->week);
 }}}

 The url will like "http://example.com/?m=2006&w=52".

 {{{
 $date = sprintf(__('%1$d-%2$02d-%3$02d 00:00:00'), $arcresult->year,
 $arcresult->month, $arcresult->dayofmonth);
 $text = mysql2date($archive_day_date_format, $date);
 }}}

 $date will like "2006-12-01 00:00:00". $date must use mysql style date
 formatting because it will be used in mysql2date function.

 These two strings shouldn't be i18ned.

 Uh, the strings which should be i18ned are:
 {{{
 // options for daily archive (only if you over-ride the general date
 format)
 $archive_day_date_format = 'Y/m/d';

 // options for weekly archive (only if you over-ride the general date
 format)
 $archive_week_start_date_format = 'Y/m/d';
 $archive_week_end_date_format   = 'Y/m/d';
 }}}

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3438#comment:3>
WordPress Trac <http://trac.wordpress.org/>
WordPress blogging software