[wp-trac] Re: [WordPress Trac] #3014: why use the @?

[WordPress Trac]

#3014: why use the @?
-------------------------------+--------------------------------------------
 Reporter:  Denis-de-Bernardy  |        Owner:  markjaquith
     Type:  defect             |       Status:  assigned   
 Priority:  normal             |    Milestone:  2.1        
Component:  Administration     |      Version:  2.0.4      
 Severity:  major              |   Resolution:             
 Keywords:  needs-patch        |  
-------------------------------+--------------------------------------------
Changes (by markjaquith):

  * milestone:  => 2.1
  * keywords:  => needs-patch
  * status:  new => assigned
  * owner:  anonymous => markjaquith

Old description:

> Pinning down a bug on a customer server lead me to removing an '@':
>
> {{{
> Warning: dir() has been disabled for security reasons (...)
> }}}
>
> The pesky line in question was:
>
> {{{
> $themes_dir = @ dir($theme_root);
> }}}
>
> But there's plenty of other calls to:
>
> {{{
> @ dir(...)
> }}}
>
> Why in the bloody hell would anyone want WordPress to silence this kind
> of error? It should spit something along the lines of "Your host sucks,
> change it now."

New description:

 Pinning down a bug on a customer server lead me to removing an '@':

 {{{
 Warning: dir() has been disabled for security reasons (...)
 }}}

 The pesky line in question was:

 {{{
 $themes_dir = @ dir($theme_root);
 }}}

 But there's plenty of other calls to:

 {{{
 @ dir(...)
 }}}

 Why in the bloody hell would anyone want WordPress to silence this kind of
 error? It should spit something along the lines of "Your host sucks,
 change it now."

Comment:

 I agree.  And I'll bet Podz agrees too.   When we hide the sins of poorly
 configured servers, we make ''their'' shortcomings into ''WordPress''
 shortcomings in the mind of the people using WordPress, and we create a
 support burden for something that isn't even our problem.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/3014>
WordPress Trac <http://wordpress.org/>
WordPress blogging software