[wp-trac] Re: [WordPress Trac] #1412: Object unserialization using get_option fails

WordPress Trac wp-trac at lists.automattic.com
Sat Apr 22 23:37:46 GMT 2006


#1412: Object unserialization using get_option fails
----------------------------+-----------------------------------------------
       Id:  1412            |      Status:  assigned                
Component:  Administration  |    Modified:  Sat Apr 22 23:37:46 2006
 Severity:  normal          |   Milestone:  2.0.3                   
 Priority:  normal          |     Version:  1.5.1.1                 
    Owner:  westi           |    Reporter:  EricAnderson            
----------------------------+-----------------------------------------------
Changes (by westi):

  * milestone:  => 2.0.3
  * status:  new => assigned
  * owner:  anonymous => westi

Comment:

 Looking at this and the code I think all we need do here is remove the
 {{{maybe_unserialize}} from {{{get_alloptions}}} as {{{get_setting}}} does
 this anyways .

 This way unserialization will be done on the {{{get_option}}} call.

 We may want to recache the unserialized value in {{{get_settings}}} the
 first time an option value is asked for if we feel that unserializing
 _every_ time is too expensive an option - which the only reason for doing
 it {{{get_alloptions}}} that I can think of.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/1412>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list