[wp-trac] [WordPress Trac] #2638: Title output in wp_list_pages() may render $title_li with backslashes (no use of stripslashes())

WordPress Trac wp-trac at lists.automattic.com
Tue Apr 4 12:26:03 GMT 2006


#2638: Title output in wp_list_pages() may render $title_li with backslashes  (no
use of stripslashes())
-----------------------+----------------------------------------------------
       Id:  2638       |      Status:  new                     
Component:  Template   |    Modified:  Tue Apr  4 12:26:02 2006
 Severity:  trivial    |   Milestone:                          
 Priority:  normal     |     Version:  2.0.2                   
    Owner:  anonymous  |    Reporter:  lordjiem                
-----------------------+----------------------------------------------------
 When trying the new Widgets plugin, I noticed that if I use the page list
 widget, its xhtml output is badly formed:
 {{{
 <h2 class=\"widgettitle\">Pages</h2>
 }}}
 instead of
 {{{
 <h2 class="widgettitle">Pages</h2>
 }}}
 and that in spite of the fact that the call to {{{wp_list_pages()}}} is
 made with well formated input in the function {{{widget_pages()}}}.

 So it seems that the {{{$title_li}}} is not cleaned before output in the
 {{{wp_list_pages()}}} function.

 Currently it is :
 {{{
 if ( $r['title_li'] )
         $output .= '<li class="pagenav">' . $r['title_li'] . '<ul>';
 }}}
 when it should be, from my point of view:
 {{{
 if ( $r['title_li'] )
         $output .= '<li class="pagenav">' .  stripslashes($r['title_li'])
 . '<ul>';
 }}}
 to make it render correctly in xhtml.

-- 
Ticket URL: <http://trac.wordpress.org/ticket/2638>
WordPress Trac <http://wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list