[wp-meta] [Making WordPress.org] #7959: Changing thousands separator on download counter page
Making WordPress.org
noreply at wordpress.org
Sun Apr 20 19:07:50 UTC 2025
#7959: Changing thousands separator on download counter page
--------------------------------+---------------------
Reporter: threadi | Owner: (none)
Type: defect (bug) | Status: new
Priority: low | Milestone:
Component: WordPress.org Site | Resolution:
Keywords: has-patch |
--------------------------------+---------------------
Changes (by ryelle):
* keywords: => has-patch
Comment:
> So the question for me is how why the thousand separators are wrong when
the page is first loaded?
When the page is first loaded, it uses the site's locale for
`number_format_i18n`, which is English here, so it loads with commas. If
you go to https://es.wordpress.org/download/counter/, it will load
initially with dots. The subsequent updates are pulled from the API which
uses the user locale as @Otto42 mentioned, which is why it changes to dots
for you (just like the Spanish site changes to commas for me).
I've got a PR to fix that here: https://github.com/WordPress/wporg-
main-2022/pull/555
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/7959#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list