[wp-meta] [Making WordPress.org] #7952: Incorrect committer attribution when using Release Confirmation

[Making WordPress.org]

#7952: Incorrect committer attribution when using Release Confirmation
------------------------------+------------------------
 Reporter:  jorgeatorres      |       Owner:  dd32
     Type:  defect (bug)      |      Status:  reviewing
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:                    |
------------------------------+------------------------

Comment (by dd32):

 > 9.7.1 to albarin and jorgeatorres. Actual committer: jorgeatorres.

 It looks like this could be a SVN log parsing issue, but I don't think
 `svn log` is used in this code path..

 Looking at 6.7.1:

 https://plugins.trac.wordpress.org/log/woocommerce/tags/9.7.1

 The metadata has listed both
 [https://plugins.trac.wordpress.org/changeset/3245739 r3245739] and
 [https://plugins.trac.wordpress.org/changeset/3250536 r3250536] against
 v9.7.1, which is incorrect but kind of makes sense when you look at the
 above svn log.

 However, that might be a coincidence, as looking at  9.8.1 has
 [https://plugins.trac.wordpress.org/changeset/3250536 r3250536] (9.7.1)
 and [https://plugins.trac.wordpress.org/changeset/3269650 r3269650] (9.8.1
 copied from trunk) listed against it too. Note that the 9.8.0 commit is
 nowhere to be seen for 9.8.1.

 I don't know why.. something odd

 > How is RC obtaining the list of committers?

 https://github.com/WordPress/wordpress.org/blob/7bcd368b66c9e098bce1314a9f4af61d7ac067a1/wordpress.org/public_html
 /wp-content/plugins/plugin-directory/cli/class-import.php#L200-L208

 I'm suspecting the `$last_release` is incorrect somewhere where it's
 calling `add_release()` - as they get merged together if `add_release()`
 is called again.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/7952#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org