[wp-meta] [Making WordPress.org] #6507: Add "Changes Requested" sections to Trac reports

[Making WordPress.org]

#6507: Add "Changes Requested" sections to Trac reports
-------------------------+---------------------
 Reporter:  desrosj      |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:
Component:  Trac         |  Resolution:
 Keywords:               |
-------------------------+---------------------

Old description:

> Recently, a `changes-requested` keyword was introduced in Core Trac.
>
> We should update the reports that are workflow oriented to include a
> section for this new workflow state:
> - [https://core.trac.wordpress.org/report/6 Report 2] (All tickets,
> workflow oriented)
> - [https://core.trac.wordpress.org/report/6 Report 6] (next major
> release, workflow oriented)
> - [https://core.trac.wordpress.org/tickets/minor/workflow Report 4] (next
> minor release, workflow oriented)
> - [https://core.trac.wordpress.org/report/8 Report 8] (Future releases,
> Workflow Oriented)
>
> There's likely a few more.
>
> Discussion related to adding the keyword:
> https://wordpress.slack.com/archives/C18723MQ8/p1650951302813149. Added
> in [r11798].

New description:

 Recently, a `changes-requested` keyword was introduced in Core Trac.

 We should update the reports that are workflow oriented to include a
 section for this new workflow state:
 - [https://core.trac.wordpress.org/report/2 Report 2] (All tickets,
 workflow oriented)
 - [https://core.trac.wordpress.org/report/6 Report 6] (next major release,
 workflow oriented)
 - [https://core.trac.wordpress.org/report/4 Report 4] (next minor release,
 workflow oriented)
 - [https://core.trac.wordpress.org/report/8 Report 8] (Future releases,
 Workflow Oriented)

 There's likely a few more.

 Discussion related to adding the keyword:
 https://wordpress.slack.com/archives/C18723MQ8/p1650951302813149. Added in
 [r11798].

--

Comment (by SergeyBiryukov):

 Replying to [ticket:6507 desrosj]:
 > Recently, a `changes-requested` keyword was introduced in Core Trac.
 >
 > We should update the reports that are workflow oriented to include a
 section for this new workflow state:
 > - [https://core.trac.wordpress.org/report/2 Report 2] (All tickets,
 workflow oriented)
 > - [https://core.trac.wordpress.org/report/6 Report 6] (next major
 release, workflow oriented)
 > - [https://core.trac.wordpress.org/report/4 Report 4] (next minor
 release, workflow oriented)
 > - [https://core.trac.wordpress.org/report/8 Report 8] (Future releases,
 Workflow Oriented)

 This is now addressed for the reports mentioned.

 Started looking into this after noticing that tickets on these reports
 have not been ordered correctly for a while, and ticket groups were
 displayed multiple times with different tickets, instead of being combined
 in a single location, see an example on the screenshot.

 After some investigation, the SQL conditionals at the top of the report
 query need to match the ones at the bottom, e.g.
 {{{
 SELECT CASE
   WHEN keywords LIKE '%fixed_major%'
   THEN 'Needs Merging from Trunk'
   WHEN ( keywords LIKE '%dev_reviewed%' AND keywords LIKE '%commit%' )
   THEN 'Commit Candidates with Dev Review'
   WHEN ( keywords LIKE '%dev_feedback%' AND keywords LIKE '%commit%' )
   THEN 'Commit Candidates which need Dev Review'
   ...
 }}}
 should correspond to:
 {{{
 ORDER BY CASE
   WHEN keywords LIKE '%fixed_major%'
   THEN 0
   WHEN ( keywords LIKE '%dev_reviewed%' AND keywords LIKE '%commit%' )
   THEN 1
   WHEN ( keywords LIKE '%dev_feedback%' AND keywords LIKE '%commit%' )
   THEN 2
   ...
 }}}
 There were some discrepancies, specifically `WHEN keywords LIKE
 '%changes_requested%'` was missing at the bottom. This is also resolved
 now.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6507#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org