[wp-meta] [Making WordPress.org] #6877: Slack icon incorrectly showing for URLs on Make

Making WordPress.org noreply at wordpress.org
Tue Mar 21 18:25:13 UTC 2023


#6877: Slack icon incorrectly showing for URLs on Make
--------------------------------------+---------------------
 Reporter:  desrosj                   |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:
Component:  Make (Get Involved) / P2  |  Resolution:
 Keywords:  has-patch                 |
--------------------------------------+---------------------

Comment (by desrosj):

 When looking to make a patch, it seems other areas of the CSS have adopted
 `a[href*="//wordpress.slack.com"]`. This still uses `*=` matching, but
 makes it specific only to the `wordpress.slack.com` instance while
 allowing for both `http` and `https` links. The bug described here would
 still occur.

 A
 [https://www.google.com/search?q=site%3Amake.wordpress.org+%22http%3A%2F%2Fwordpress.slack.com%22&sxsrf
 =AJOqlzUD0h94FdexEQZx2qTekLEJ2D-oXw%3A1679423007686&source=hp&ei
 =H_YZZPjhJumbptQPy6KC-
 AM&iflsig=AK50M_UAAAAAZBoEL_8gz8GVI4H3tSc3DiK0an9-grXJ&ved=0ahUKEwi47bCe0u39AhXpjYkEHUuRAD8Q4dUDCAk&uact=5&oq=site%3Amake.wordpress.org+%22http%3A%2F%2Fwordpress.slack.com%22&gs_lcp=Cgdnd3Mtd2l6EAM6BwgjEOoCECdQcVhxYIYIaAFwAHgAgAFMiAFMkgEBMZgBAKABAqABAbABCg&sclient
 =gws-wiz Google search shows that there are no indexed instances] of
 `http://wordpress.slack.com` on make.wordpress.org.

 I think it's safe to change the rule to
 `a[href^="https://wordpress.slack.com"]`.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6877#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list