[wp-meta] [Making WordPress.org] #7085: Correct various "plugin type" issues

[Making WordPress.org]

#7085: Correct various "plugin type" issues
------------------------------+---------------------
 Reporter:  jonoaldersonwp    |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  high              |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:  seo performance   |
------------------------------+---------------------

Comment (by dd32):

 Replying to [comment:2 jonoaldersonwp]:
 > We'll still need canonical URLs, then, which include the business model
 string.

 Yep, I agree.

 Some notes while looking at this:

 > Filtered states omit a canonical URL tag

 https://wordpress.org/plugins/browse/blocks/?plugin_business_model=community
 doesn't contain a canonical link, as it's a multi-taxonomy query which we
 don't currently support canonical links for right now.
 Because from a code point of view, it's not possible to determine which
 taxonomy is the "primary" one and which should appear as query vars. We
 can probably add minimal support by doing something like "if multi
 taxonomy, and only one has a pretty-permalink, we can assume that's
 primary".

 > Requests to out-of-bounds filtered ranges

 https://wordpress.org/plugins/browse/blocks/page/2/?plugin_business_model=community
 is redirected by `Plugin_Directory->custom_redirects:1278`, same thing
 which redirects urls like `/plugins/browse/somethingrandom/` or
 `/plugins/browse/blocks/sillyendpoint/`.

 I don't think a redirect is actually the proper thing here, probably a 404
 is more appropriate.

 The actual problem I think is that
 https://wordpress.org/plugins/browse/blocks/page/2/ links to this
 problematic URL, the Community/Commercial links here should likely remove
 the pagination state.

 > The 'all' link on paginated+filtered states

 Again, these urls should be omitting any pagination data I think, which I
 think would resolve this.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/7085#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org