[wp-meta] [Making WordPress.org] #7388: Github PR linking can get confused

[Making WordPress.org]

#7388: Github PR linking can get confused
--------------------------+--------------------
 Reporter:  dd32          |      Owner:  (none)
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:
Component:  Trac          |   Keywords:
--------------------------+--------------------
 As experienced with https://github.com/WordPress/wordpress.org/pull/186 +
 https://meta.trac.wordpress.org/ticket/7382 sometimes the GitHub PR
 linking gets confused as to the correct ticket to interact with.

 It appears that it treated a Themes.trac link as a meta.trac link, and
 subsequently threw an unhandled exception.

 The exception shouldn't have occurred, but it should've been handled
 gracefully as well.

 Exception generated by the above PR:
 {{{
 E_ERROR: Uncaught Exception: JSON Error: 404 Ticket 158677 does not exist.
 in dotorg/trac/pr/class-trac.php:145

 Stack trace:
 #0 dotorg/trac/pr/class-trac.php(104):
 WordPressdotorg\API\Trac\GithubPRs\Trac->_api('ticket.update', Array)
 #1 dotorg/trac/pr/class-trac.php(45):
 WordPressdotorg\API\Trac\GithubPRs\Trac->api('ticket.update', Array)
 #2 dotorg/trac/pr/webhook.php(149):
 WordPressdotorg\API\Trac\GithubPRs\Trac->update('158677', '''This ticket
 w...', Array, true)
 #3 {main}
  thrown
 Source: POST https://api.wordpress.org/dotorg/trac/pr/webhook.php
 }}}

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/7388>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org