[wp-meta] [Making WordPress.org] #6812: Content overflow issue on search form

Making WordPress.org noreply at wordpress.org
Wed Aug 30 21:51:11 UTC 2023

#6812: Content overflow issue on search form
 Reporter:  baroliyamayur                |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:
Component:  Plugin Directory             |  Resolution:
 Keywords:  needs-patch has-screenshots  |

Comment (by coffee2code):

 @baroliyamayur: Thanks for the report and the patch!

 Your patch (here and under other tickets) includes the accumulated changes
 you've made to WordPress.org code for a number of different tickets
 (there's stuff in there for the Theme Directory, BuddyPress, Photo
 Directory, etc). And while it looks like you have the compiled `wporg-
 plugins/css/style.css` change that reflects your fix for this, you didn't
 include the .sass source file for that change, `wporg-

 I recommend two things for your patches going forward:

 1. Check to ensure you're only including the necessary changes and changed
 files necessary to fix the issue in the ticket.
 2. There's no need to include compiled files (.css or .js) that are
 generated as the result of a build process. Whoever commits the change
 will run the build process themselves since there will likely have been
 other changes in the meantime, and to ensure no other changes were snuck
 into the compiled files. Including the compiled files also makes the diff
 look much bigger than it is and harder to identify the true changes.

 No worries about this ticket though, as I'm about to commit the fix.

Ticket URL: <https://meta.trac.wordpress.org/ticket/6812#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org

More information about the wp-meta mailing list