[wp-meta] [Making WordPress.org] #6443: /page/2/ being adding to reply links incorrectly

[Making WordPress.org]

#6443: /page/2/ being adding to reply links incorrectly
----------------------------+---------------------
 Reporter:  sterndata       |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  high            |   Milestone:
Component:  Support Forums  |  Resolution:
 Keywords:                  |
----------------------------+---------------------

Comment (by dd32):

 Replying to [comment:12 bcworkz]:
 > >It's not immediately obvious to me as to why there are missing reply
 position numbers in there..
 > I'm pretty sure the missing replies were spam replies that have been
 deleted. Apparently the reply count does not get updated when spam is
 removed, causing the pagination to behave as though the spam is still
 there.

 That would certainly account for it!

 Looking at bbPress, I only see `bbp_update_reply_position()` being called
 for merged/split topics, and from within the reply-position repair tool.

 Perhaps what we should be looking at here is having
 `bbp_update_reply_position()` run for topics after any reply is
 archived/spammed/deleted.

 This feels like it's an upstream bbPress bug, but one that we can probably
 patch over on w.org while we figure out a way to reproduce it in a test
 case for upstream fixing.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6443#comment:13>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org