[wp-meta] [Making WordPress.org] #6059: Display style variations for block themes in the theme directory
Making WordPress.org
noreply at wordpress.org
Thu Oct 6 04:07:46 UTC 2022
#6059: Display style variations for block themes in the theme directory
-----------------------------+---------------------
Reporter: poena | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Theme Directory | Resolution:
Keywords: |
-----------------------------+---------------------
Comment (by dufresnesteven):
I added a patch attachment:6059.diff which along with the pull request
referenced below will add style variations to theme views. Once the pull
request is complete, I will deploy the diff which will add the
functionality and can be triggered via a query string parameter so we can
test in production and iterate on feedback before the official rollout of
the feature.
On page load, the control does all-of-a-sudden push content down once the
ajax request completes. We currently don't have a way on page load to
determine if there are style variations in the theme. I have asked in the
slack #themereview channel if there will be a tag added for style
variations. If we had a tag, we could display the control while loading
the variations and avoid the jump. The alternative is to add some metadata
on theme upload which will work, but it's currently very cumbersome to add
a new property to the theme API and backfill all the data. The tag
approach would put the onus on the theme developer, but we would probably
have style variations in themes where the developer has not added the tag.
That's obviously not ideal.
Regardless, I will push to find a solution here but it's currently not in
place. I don't think it should block some live testing.
**References:**
Component Pull Request: [https://github.com/WordPress/wporg-mu-
plugins/pull/289]
Slack msg about style-variation tag:
https://wordpress.slack.com/archives/C02RP4Y3K/p1664949151352129
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/6059#comment:13>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list