[wp-meta] [Making WordPress.org] #6588: Allow multiple changes on one topic edit

[Making WordPress.org]

#6588: Allow multiple changes on one topic edit
----------------------------+---------------------
 Reporter:  sterndata       |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:
Component:  Support Forums  |  Resolution:
 Keywords:                  |
----------------------------+---------------------
Changes (by dd32):

 * component:  General => Support Forums


Comment:

 I couldn't see any reason this would happen at first glance.. until I
 tested it.

 The handler to move a topic between forums runs before the handler to set
 the NSFW flag.

 In my testing, the operation to move between forums times out with a 504
 error during the move, causing the NSFW flag handler to never run.

 The order of operations is something like this:
 > 1. Update thread/reply contents
 > 2. Move topic to different forum
 > 3. Update topic replies to the new forum
 > 4. Recount forum thread counts for old and new forums <--- Times out
 here
 > 5. Process extra thread operations (Including the NSFW handler)

 We'd need to figure out how to disable bbPress forum counting in order to
 fix this.

 Move handler:
 https://github.com/bbpress/bbPress/blob/394ae31c059228e866240076db2dc2ca2ddc8a7c/src/includes/topics/functions.php#L950-L1083

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6588#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org