[wp-meta] [Making WordPress.org] #6327: All channels are treated as private groups

[Making WordPress.org]

#6327: All channels are treated as private groups
--------------------------+---------------------
 Reporter:  Clorith       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:
Component:  Slack & IRC   |  Resolution:
 Keywords:                |
--------------------------+---------------------
Description changed by Clorith:

Old description:

> After r11878, all `/here` and similar calls are treating the channels as
> private groups.
>
> This appears to be caused by a missing
> [https://meta.trac.wordpress.org/browser/sites/trunk/common/includes/slack/announce/lib.php?rev=11878#L177
> `$` on line 177], which in PHP <8 only throws a warning, and interprets
> as true, leading the conditional to pass and set the channel type as
> `privategroup`.

New description:

 After r11878, all `/here` and similar calls are treating the channels as
 private groups.

 This appears to be caused by a missing
 [https://meta.trac.wordpress.org/browser/sites/trunk/common/includes/slack/announce/lib.php?rev=11878#L177
 `$` on line 177], which in PHP <8 only throws a warning, and interprets as
 true, leading the conditional to pass and set the channel type as
 `privategroup`.

 Props @annezazu for noticing!

--

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6327#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org