[wp-meta] [Making WordPress.org] #6195: Quick Edit and other JS broken on .org
Making WordPress.org
noreply at wordpress.org
Wed Mar 16 10:52:23 UTC 2022
#6195: Quick Edit and other JS broken on .org
--------------------------+---------------------
Reporter: tobifjellner | Owner: (none)
Type: defect (bug) | Status: new
Priority: high | Milestone:
Component: General | Resolution:
Keywords: |
--------------------------+---------------------
Comment (by ocean90):
@youknowriad The 1 argument is [https://github.com/WordPress/wordpress-
develop/blob/573581f43f63f12cc37620172432cf93745f568c/src/wp-
includes/class.wp-scripts.php#L541-L542 a special case handled by
WP_Scripts]. The scripts should be correctly registered for in the footer.
> I’m not sure yet how it’s related to the commit about empty translations
Scripts which have inline scripts assigned won't get concatenated via
load-scripts.php thus we ended at something like this:
{{{
<script id='common-js-translations'>
( function( domain, translations ) {
var localeData = translations.locale_data[ domain ] ||
translations.locale_data.messages;
localeData[""].domain = domain;
wp.i18n.setLocaleData( localeData, domain );
} )( "default", { "locale_data": { "messages": { "": {} } } } );
</script>
<script src='http://localhost:8889/wp-
admin/js/common.min.js?ver=6.0-alpha-52448-src' id='common-js'></script>
}}}
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/6195#comment:9>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list