[wp-meta] [Making WordPress.org] #6364: Optimize the syntax for judging whether to add "-" when preparing parameters in the SVN tool in the plugin directory

Making WordPress.org noreply at wordpress.org
Wed Jun 15 23:53:16 UTC 2022


#6364: Optimize the syntax for judging whether to add "-" when preparing
parameters in the SVN tool in the plugin directory
------------------------------+------------------------------------
 Reporter:  sunxiyuan         |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  lowest            |   Milestone:  Plugin Directory v3.0
Component:  Plugin Directory  |  Resolution:
 Keywords:  has-patch         |
------------------------------+------------------------------------
Changes (by dd32):

 * priority:  normal => lowest


Old description:

> {{{
> !str_starts_with( $key, '-' )
> }}}
>
> to
>
> {{{
> '-' != substr( $key, 0, 1 )
> }}}

New description:

 {{{
 '-' != substr( $key, 0, 1 )
 }}}

 to

 {{{
 !str_starts_with( $key, '-' )
 }}}

--

Comment:

 Fixed description, it was the inverse of what you intended on saying :)

 There's nothing wrong with the existing code, and any micro-optimizations
 here aren't going to make any form of impact.

 That being said, I'll commit this, so we don't have the PR/ticket left
 open.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6364#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list