[wp-meta] [Making WordPress.org] #6383: Highlight start/end spaces and single space strings

Making WordPress.org noreply at wordpress.org
Tue Jul 5 06:46:35 UTC 2022


#6383: Highlight start/end spaces and single space strings
--------------------------------------+-----------------------
 Reporter:  psmits1567                |       Owner:  (none)
     Type:  enhancement               |      Status:  reopened
 Priority:  normal                    |   Milestone:
Component:  Translate Site & Plugins  |  Resolution:
 Keywords:                            |
--------------------------------------+-----------------------
Changes (by dd32):

 * status:  closed => reopened
 * resolution:  reported-upstream =>
 * reporter:  psmits1568 => psmits1567


Comment:

 Replying to [comment:2 psmits1567]:

 I agree.

 However, the ticket asked for `It would be great if that position is
 highlighted within the editor` which is the Upstream GlotPress ticket -
 That's why I closed it in favour of that.

 Notably though.. There's two areas where we handle leading/trailing new
 lines but NOT leading/trailing SPACES
  - Client-side JS validation for missing new lines:
 https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
 /wp-content/plugins/wporg-gp-js-warnings/wporg-gp-js-
 warnings.js?marks=148-179#L134
  - the translation fixer fixes singular missing leading/trailing newlines;
 https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
 /wp-content/plugins/wporg-gp-translation-fixer/wporg-gp-translation-
 fixer.php?marks=52-64#L48

 Adding support for spaces to both of those isn't out of the question at
 all, but that wasn't what was originally proposed in this ticket.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/6383#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list