[wp-meta] [Making WordPress.org] #5818: Theme preview is not working for block themes

Making WordPress.org noreply at wordpress.org
Tue Sep 7 10:21:33 UTC 2021


#5818: Theme preview is not working for block themes
-----------------------------+---------------------
 Reporter:  kafleg           |       Owner:  (none)
     Type:  defect           |      Status:  closed
 Priority:  high             |   Milestone:
Component:  Theme Directory  |  Resolution:  fixed
 Keywords:  needs-patch      |
-----------------------------+---------------------

Comment (by oandregal):

 :wave: I was working on a similar issue that affected the customizer and
 themes that use the global stylesheet generated by theme.json. For
 reference, this is the issue
 https://github.com/WordPress/gutenberg/issues/34531 It turns out there was
 a cache issue that I'm fixing at
 https://github.com/WordPress/gutenberg/pull/34540

 By looking at the themes under https://wordpress.org/themes/tags/full-
 site-editing/ I believe what happens there may be related to the
 customizer bug I've ran into.

 Here's what I'm doing to test:

 - Load the preview of one of the themes listed at
 https://wordpress.org/themes/tags/full-site-editing/
 - Inspect the contents of the `global-styles-inline-css` embedded
 stylesheet.
 - I expect the `global-styles-inline-css` stylesheet to contain theme-
 specific styles (block styles, preset classes defined by the theme, etc).

 When the preview fails to look like the theme, what I find is that the
 `global-styles-inline-css` stylesheet only contains the general styles
 (`body` selector with CSS Custom Properties + some `.has-*` classes
 provided by core) but not the theme-specific ones.

 Can we test whether https://github.com/WordPress/gutenberg/pull/34540 will
 fix this as well? I'm not sure how meta is set up, but a potential
 harmless and manual testing could be to add that line at
 https://github.com/WordPress/wordpress-
 develop/blob/f49d48fdcb30f48307ccab183f9103d8b4527e5c/src/wp-includes
 /default-filters.php#L338

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5818#comment:4>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list