[wp-meta] [Making WordPress.org] #5966: Give a message when string is too short or wrong in the consistency tool
Making WordPress.org
noreply at wordpress.org
Sat Nov 27 15:13:42 UTC 2021
#5966: Give a message when string is too short or wrong in the consistency tool
--------------------------------------+---------------------
Reporter: NekoJonez | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Translate Site & Plugins | Resolution:
Keywords: |
--------------------------------------+---------------------
Comment (by vladytimy):
I think this is caused by evaluating {{{0}}} string value of {{{$search}}}
to falsey on this line, hence it thinks there is no term to perform a
search for.
{{{
if ( $search && $locale && $set_slug )
$performed_search = true;
}}}
[https://github.com/WordPress/wordpress.org/blob/c54eb93f3f27d02bba495f6a418db2316e9a03c6/wordpress.org/public_html
/wp-content/plugins/wporg-gp-routes/inc/routes/class-consistency.php#L65
Source file]
It's an edge case but maybe the comparsion should be {{{search !== ''}}}
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5966#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list