[wp-meta] [Making WordPress.org] #5942: DevHub: Support viewing source on GitHub mirror
Making WordPress.org
noreply at wordpress.org
Thu Nov 4 22:32:29 UTC 2021
#5942: DevHub: Support viewing source on GitHub mirror
---------------------------+-----------------------
Reporter: netweb | Owner: dd32
Type: enhancement | Status: reopened
Priority: normal | Milestone:
Component: Developer Hub | Resolution:
Keywords: needs-patch |
---------------------------+-----------------------
Comment (by coffee2code):
Replying to [comment:8 dd32]:
>
> Kind of seems weird that the source-code for the hook isn't displayed
within the "Source" heading though, given it's only a single line usually,
it might be worth duplicating it there?
>
For consistency and completeness, I wouldn't be opposed to having the line
of code for each hook to be included. I can include them in the parsing of
5.8.2 (at the latest) when it lands, or sooner if I get a chance. It
requires a CLI run to pre-cache source code after a necessary code
adjustment has been committed.
>
>
[https://developer.wordpress.org/reference/classes/twenty_fourteen_ephemera_widget/__construct/
twenty_fourteen_ephemera_widget::__construct] and similar theme class
methods are probably a good example, I'm sure I've seen another one but I
can't think of it off the top of my head.
>
Ah, thanks. Those shouldn't exist and have been deleted. In the early days
of the Code Reference, parsings included bundled themes, but were quickly
deemed not to be included. Much of those parsed theme resources had since
been deleted. Looks like a handful of methods (including the one you
mentioned) and a couple hooks still persisted, but are gone now.
So I'm not surprised that with those methods existing that their source
codes were understandably missing. However, any legitimate
functions/methods/classes should have the proper source code embeds.
>
>
[https://developer.wordpress.org/reference/classes/twenty_fourteen_ephemera_widget
the class definition] doesn't even exist
>
As noted, this is the proper situation since theme-specific data shouldn't
exist.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5942#comment:9>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list