[wp-meta] [Making WordPress.org] #5940: Plugin Directory: Editing plugin has errant %s

[Making WordPress.org]

#5940: Plugin Directory: Editing plugin has errant %s
------------------------------+---------------------
 Reporter:  Ipstenu           |       Owner:  (none)
     Type:  defect            |      Status:  new
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:                    |
------------------------------+---------------------

Comment (by SergeyBiryukov):

 It looks like this is a result of a WP core change in [WP51969], which
 aims to include the title of the post being edited in the `<title>` tag.

 I haven't tested [attachment:"5940.diff"] yet. At a glance, I think it
 would fix the page title, but break the `<h1>` heading on the screen:
 `Editing Plugin: Gutenberg` would become just `Editing Plugin:`, as the
 [source:sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-
 directory/admin/class-customizations.php?marks=68-81#L66
 replace_title_global()] method would no longer have the placeholder to
 replace.

 So I think this needs some more work. Maybe adjusting
 `replace_title_global()` to match the core change would be enough. See
 [attachment:"5940.2.diff"].

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5940#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org