[wp-meta] [Making WordPress.org] #5749: GitHub integration: Showing "All checks pass" on failing PR

[Making WordPress.org]

#5749: GitHub integration: Showing "All checks pass" on failing PR
--------------------+---------------------
 Reporter:  ryelle  |       Owner:  (none)
     Type:  defect  |      Status:  new
 Priority:  normal  |   Milestone:
Component:  Trac    |  Resolution:
 Keywords:          |
--------------------+---------------------

Comment (by dd32):

 (This is a note for myself, and any others who look at it, mostly thinking
 out loud)

 Before opening the trac ticket up, I looked at the cached data:

 > `"mergeable_state":"unknown","check_runs":[],"reviews":[],`

 After loading the ticket, I saw
 > ✅ All checks pass, GitHub Actions running

 And I can now see the cached data is updated to be
 > `"mergeable_state":"blocked","check_runs":{"GitHub
 Actions":"in_progress"},"reviews":[],`

 At a guess, I'm thinking an API request to GitHub may have timed out,
 resulting in no `check_runs` being cached, resulting in an all-checks-
 pass?

 Having no `check_runs` is expected for some PRs, for example to
 WordPress/wordpress.org, but not for core trac. But having `All checks
 pass` without `check_runs` doesn't make sense, until you consider that for
 meta it shows whether it can be merged or not (even tho we don't merge PRs
 on GitHub)

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5749#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org