[wp-meta] [Making WordPress.org] #5564: WordPress.org secret-key service output does not follow coding standards

Making WordPress.org noreply at wordpress.org
Thu Jan 7 22:54:03 UTC 2021


#5564: WordPress.org secret-key service output does not follow coding standards
-------------------------+---------------------
 Reporter:  johnpgreen   |       Owner:  (none)
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:
Component:  API          |  Resolution:
 Keywords:  close        |
-------------------------+---------------------
Changes (by dd32):

 * keywords:   => close
 * component:  General => API


Comment:

 IMHO: The salt API should never be used directly, but it exists for legacy
 reasons.  It's primarily only used by those who create a `wp-config.php`
 file manually, and even then I question how many actually use it.

 Unfortunately the output cannot be changed, as WordPress expects it to be
 in the current format: https://core.trac.wordpress.org/browser/trunk/src
 /wp-admin/setup-config.php?marks=348-351#L335

 Actually, I guess I could fix the API output.. but it would require
 violating a different coding standards rule, `SECURE_AUTH_SALT` would have
 to live without having a space after the comma in the `define()`.

 While I could bump the version to `1.2` it doesn't seem to serve much
 purpose in doing so, as it should be rare that the API is needed anymore.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5564#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list