[wp-meta] [Making WordPress.org] #4126: "Special contributions" template leaks PII

[Making WordPress.org]

#4126: "Special contributions" template leaks PII
-----------------------------------------+-----------------------
 Reporter:  jonoaldersonwp               |       Owner:  dd32
     Type:  defect                       |      Status:  accepted
 Priority:  high                         |   Milestone:
Component:  Codex                        |  Resolution:
 Keywords:  seo analytics privacy close  |
-----------------------------------------+-----------------------

Comment (by dd32):

 In r11568-codex I've updated the noindex code to be this:

 {{{
 // Noindex various pages. See Meta #4373, #4127, #4126.
 $noindex = (
         // No article
         (
                 $pageOutput->isArticleRelated() && !
 $pageOutput->getRevisionId()
         ) ||
         // The User, Special, and File namespaces are not indexed.
         in_array(
                 $pageOutput->getTitle()->getNsText(),
                 array(
                         'User_talk',
                         'User',
                         'Special',
                         'File',
                 ),
                 true
         ) ||
         // It's an internal 'index.php?..' page
         preg_match( '~^/index\.php~', $_SERVER['REQUEST_URI'] )
 );
 }}}

 That seems to match all pages I could find, just need to wait upon a
 systems deploy / cache clear again.

 There's a bunch of `is....()` functions in MediaWiki that could be used,
 but it wasn't straight forward to use those functions I found due to the
 number of them. `isArticleRelated()` is also truthful for user pages, as
 is wiki pages.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/4126#comment:15>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org