[wp-meta] [Making WordPress.org] #5693: Allow themes to re-use a rejected slug
Making WordPress.org
noreply at wordpress.org
Wed Apr 7 00:53:07 UTC 2021
#5693: Allow themes to re-use a rejected slug
-----------------------------+---------------------
Reporter: dd32 | Owner: (none)
Type: enhancement | Status: new
Priority: low | Milestone:
Component: Theme Directory | Resolution:
Keywords: 2nd-opinion |
-----------------------------+---------------------
Comment (by dd32):
Replying to [comment:1 joyously]:
> I'm in favor of this, but does this affect Trac at all? Would there be
old tickets pointing to nowhere?
Yes, Old tickets would point to no-longer-existing locations as they
unfortunately don't reference exact revisions.
The other issue with themes, is that the existing kind-of-broken keyword
searching would return related tickets for both the now-rejected theme and
the new theme taking it's place. That's not too much of a problem IMO, as
a theme called 'GRE' with `theme-gre` would already list `theme-gre,
theme-green, theme-green-garden`..
Looking at how to make Trac note the location of the code / tickets are no
longer relevant would be a good idea. I'm not afraid of breaking 2+ year
old ticket links though, since they're.. I'll be surprised if anyone ever
actually looks at them.
Replying to [comment:2 Ipstenu]:
> We use rejected-PLUGIN-rejected to ensure no possible bad-hits (like
someone making a theme named 'green-rejected' ... look, it could happen).
Actually, I think we used that as different code elsewhere expected it to
be suffixed or prefixed so we just did both.. but there's no reason why
not to do it here either :)
> Would it be possible to _rename_ the SVN repo to that? I can see cases
where you'd want to keep the history.
Nothing in SVN is ever truely deleted, renaming is possible though. The
biggest different is that for a deletion to browse that code you'd have to
pull up an old revision of the url in Trac.
Deleting may also benefit in other ways though, like being able to check
out themes.svn to pull all themes (don't do that folks) or for
themes.trac/browser to actually work again.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5693#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list