[wp-meta] [Making WordPress.org] #5429: PHP Coding Standards - Yoda Conditionals - Absolute Phrasing

[Making WordPress.org]

#5429: PHP Coding Standards - Yoda Conditionals - Absolute Phrasing
---------------------------+--------------------------------
 Reporter:  sabernhardt    |       Owner:  (none)
     Type:  enhancement    |      Status:  closed
 Priority:  normal         |   Milestone:
Component:  Developer Hub  |  Resolution:  reported-upstream
 Keywords:                 |
---------------------------+--------------------------------
Changes (by dd32):

 * status:  new => closed
 * resolution:   => reported-upstream


Comment:

 Hi @sabernhardt & @theistand,

 Meta isn't the right team to deal with this ticket, core is the better
 place IMHO.
 However, [https://wordpress.slack.com/archives/C5VCTJGH3/p1599695164014700
 I raised it directly with the team] and it's been suggested
 https://github.com/WordPress/wpcs-docs is probably a better place.

 You can also reach out to the team in #core-coding-standards on the Making
 WordPress slack (see https://chat.wordpress.org/)

 I'm also going to copy @jrf's response here for reference for those who
 don't have a Slack account:

 > Thanks dd32 for the ping. This should actually be handled in this repo:
 https://github.com/WordPress/wpcs-docs
 >
 > As for the arguments the op makes: I totally agree that Yoda conditions
 are redundant and the current CS check for them is laughable as it only
 checks for comparison operators, NOT assignment operators, which is what
 Yoda is supposed to be about (preventing assignments in condition).
 >
 > I realize there is a lot of division in the opinions about Yoda, so it
 is on my list of future posts to put up on Make to open it up for a
 broader discussion.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5429#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org