[wp-meta] [Making WordPress.org] #5464: Plugin Directory: Prevent SVN uploads of animated banners and icons

Making WordPress.org noreply at wordpress.org
Thu Oct 8 02:58:16 UTC 2020


#5464: Plugin Directory: Prevent SVN uploads of animated banners and icons
------------------------------+---------------------
 Reporter:  Ipstenu           |       Owner:  (none)
     Type:  defect            |      Status:  new
 Priority:  normal            |   Milestone:
Component:  Plugin Directory  |  Resolution:
 Keywords:                    |
------------------------------+---------------------

Comment (by dd32):

 There are four things that need to be accounted for here:
 1. Multi frame Gifs
 2. Animated PNGs
 3. The above uploaded as a .jpg
 4. SVGs with CSS transitions or `<animate>` tags

 There's several options that I can think of..
  - For 1-3 is to proxy the image via something that strips the animation
  - For 1-3 upon plugin parse, detect multi-frame images and ignore them
  - For 4 (SVGs) `SVGRoot.pauseAnimations()` should work for the animation
 tags, but I don't think that'll affect any JS/CSS transitions..

 One of the complexities here is that the ps.w.org cdn where these images
 are loaded from is just a caching code-less cdn based on
 plugins.svn.wordpress.org, so inserting something else in there between
 SVN and clients is not super ideal.

 I guess that means that the ideal place to handle this is at plugin import
 time, but the limitations there is that it means you can't strip it back
 to being a single frame when it's detected to be animated without also
 making a commit to svn.

 Detecting animated images and looking for `animate` within SVGs and
 ignoring them if present is probably the simplest option here.

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5464#comment:3>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list