[wp-meta] [Making WordPress.org] #5157: Update URL on search actions
Making WordPress.org
noreply at wordpress.org
Fri May 1 08:34:48 UTC 2020
#5157: Update URL on search actions
----------------------------+---------------------
Reporter: jonoaldersonwp | Owner: (none)
Type: defect | Status: closed
Priority: normal | Milestone:
Component: General | Resolution: fixed
Keywords: analytics |
----------------------------+---------------------
Changes (by dd32):
* priority: highest omg bbq => normal
Comment:
> It looks like the URL is updated after the form result is returned. That
means it's too late for GTM to pick up the change easily. It needs to
change on click/submit.
Unfortunately that's because Google custom search doesn't appear to offer
any signal as to what section is selected. It can only be determined after
render.
> The category parameters aren't as per the requirements (e.g.,
https://wordpress.org/search/dogs?forums=1 should be
https://wordpress.org/search/dogs?search_category=support_forums).
Correct, They use our existing search format. I'm not changing that.
> Navigation between categories which have previously been selected
doesn't update the URL.
It does, if the search refreshes. Unfortunately Google Custom Search
doesn't have a callback to trigger on after the results are already cached
in the DOM.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5157#comment:8>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list