[wp-meta] [Making WordPress.org] #5115: Rosetta option overrides respect user locale (but shouldn't)

Making WordPress.org noreply at wordpress.org
Wed Mar 25 02:40:42 UTC 2020


#5115: Rosetta option overrides respect user locale (but shouldn't)
-------------------------------------------+---------------------
 Reporter:  dd32                           |       Owner:  (none)
     Type:  defect                         |      Status:  new
 Priority:  normal                         |   Milestone:
Component:  International Sites (Rosetta)  |  Resolution:
 Keywords:  needs-patch                    |
-------------------------------------------+---------------------
Changes (by dd32):

 * keywords:   => needs-patch


Old description:

> As reported by @nao on Slack:
> https://wordpress.slack.com/archives/C02QB8GMM/p1585101201000700
>
> The
> [https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
> /wp-content/plugins/rosetta/inc/class-plugin.php#L84 Rosetta option
> overrides] respect the user locale, rather than the site locale.
>
> When browsing as a `en_US` user locale, the
> `timezone_string`/`gmt_offset` will be set to `''`/`0`, rather than the
> expected `Asia/Tokyo`.
>
> Either the Rosetta Locale should be respected for the purpose of option
> overrides, or they should be removed and locale sites should just set the
> appropriate options themselves.

New description:

 As reported by @nao on Slack:
 https://wordpress.slack.com/archives/C02QB8GMM/p1585101201000700

 The
 [https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html
 /wp-content/plugins/rosetta/inc/class-plugin.php#L84 Rosetta option
 overrides] respect the user locale, rather than the site locale.

 When browsing ja.wordpress.org/wp-admin with a `en_US` user locale, the
 `timezone_string`/`gmt_offset` will be set to `''`/`0`, rather than the
 expected `Asia/Tokyo`.

 Either the Rosetta Locale should be respected for the purpose of option
 overrides, or they should be removed and locale sites should just set the
 appropriate options themselves.

--

-- 
Ticket URL: <https://meta.trac.wordpress.org/ticket/5115#comment:2>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org


More information about the wp-meta mailing list