[wp-meta] [Making WordPress.org] #5242: Plugins should use svn timestamps for accurate last-updated value
Making WordPress.org
noreply at wordpress.org
Tue Jun 16 18:46:02 UTC 2020
#5242: Plugins should use svn timestamps for accurate last-updated value
------------------------------+---------------------------
Reporter: tellyworth | Owner: coreymckrill
Type: enhancement | Status: accepted
Priority: low | Milestone:
Component: Plugin Directory | Resolution:
Keywords: |
------------------------------+---------------------------
Changes (by coreymckrill):
* owner: (none) => coreymckrill
* status: new => accepted
Comment:
The above patch adds a new `info` method to the `Tools\SVN` class. It also
refactors a portion of the `export_and_parse_plugin` method in
`CLI\Import` to use the new SVN method to find the correct location of the
stable branch before running an export. Finally it uses the data from the
new method to populate the plugin's "Last updated" timestamp.
In testing, using **bin/import-plugin.php**, the "Last updated" was
getting set to the correct value from the svn repo. One (possibly trivial)
side benefit is that the refactor of the export process seems to have cut
the time to process a single plugin in half--1.4 seconds vs 2.6 seconds on
my sandbox.
This probably needs more testing before merge, especially to make sure
there aren't any regressions in how `export_and_parse_plugin` handles edge
cases. I'm not sure yet how best to find and test those edge cases though.
--
Ticket URL: <https://meta.trac.wordpress.org/ticket/5242#comment:1>
Making WordPress.org <https://meta.trac.wordpress.org/>
Making WordPress.org
More information about the wp-meta
mailing list